From 016157a0eb75702cddf65e1c621d6c85d5dc35d7 Mon Sep 17 00:00:00 2001 From: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com> Date: Mon, 6 Mar 2023 16:23:13 +0100 Subject: [PATCH] Witness: Fixed settings combination not rolling (see description) Settings combination: - EP Shuffle - disable_non_randomized - doors: panels or doors: none An Event Item was being created that is inaccessible. This is fixed now. (The fix makes sure that player_logic is not trying to create events for the sake of EPs that are disabled) Note: These two sets should probably be merged anyway, they used to behave differenty but no longer really do. But that will require some extra care on the client side as well. --- worlds/witness/player_logic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/worlds/witness/player_logic.py b/worlds/witness/player_logic.py index eb5b7934..3e81993d 100644 --- a/worlds/witness/player_logic.py +++ b/worlds/witness/player_logic.py @@ -40,7 +40,7 @@ class WitnessPlayerLogic: Panels outside of the same region will still be checked manually. """ - if panel_hex in self.COMPLETELY_DISABLED_CHECKS: + if panel_hex in self.COMPLETELY_DISABLED_CHECKS or panel_hex in self.PRECOMPLETED_LOCATIONS: return frozenset() check_obj = self.REFERENCE_LOGIC.CHECKS_BY_HEX[panel_hex]