From 7bb115de725c46ffb8418c471785c055ec8ca3e7 Mon Sep 17 00:00:00 2001
From: CaitSith2 <d_good@caitsith2.com>
Date: Wed, 13 Jan 2021 10:40:23 -0800
Subject: [PATCH] Fix bug with placements always being empty.

It will never be not empty, because every placement that succeeds gets its event set to true, and the conditional expects locations already placed within the fill to also not be events.
---
 Fill.py | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/Fill.py b/Fill.py
index 218c81c2..47038a31 100644
--- a/Fill.py
+++ b/Fill.py
@@ -19,6 +19,7 @@ def fill_restrictive(world, base_state: CollectionState, locations, itempool, si
         return new_state
 
     unplaced_items = []
+    placements = []
 
     no_access_checks = {}
     reachable_items = {}
@@ -52,11 +53,6 @@ def fill_restrictive(world, base_state: CollectionState, locations, itempool, si
                         logging.warning(
                             f'Not all items placed. Game beatable anyway. (Could not place {item_to_place})')
                         continue
-                    placements = []
-                    for region in world.regions:
-                        for location in region.locations:
-                            if location.item and not location.event:
-                                placements.append(location)
                     # fill in name of world for item
                     item_to_place.world = world
                     raise FillError(f'No more spots to place {item_to_place}, locations {locations} are invalid. '
@@ -64,6 +60,7 @@ def fill_restrictive(world, base_state: CollectionState, locations, itempool, si
 
                 world.push_item(spot_to_fill, item_to_place, False)
                 locations.remove(spot_to_fill)
+                placements.append(spot_to_fill)
                 spot_to_fill.event = True
 
     itempool.extend(unplaced_items)