monorail
/
Archipelago
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[WebHost] Fix weighted-settings UI incorrectly populating range values (#1602) 

* Fix a bug causing weighted-settings UI to incorrectly display range values with no default as having a value of 25.

* Do not set min and max values of range options to zero by default. This causes clutter in saved `.yaml` files.
This commit is contained in:
Chris Wilson 2023-03-27 11:55:13 -04:00 committed by GitHub
parent f0403b9c9d
commit 21c6c28755
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
WebHostLib/static/assets/weighted-settings.js
View File

@ -78,8 +78,6 @@ const createDefaultSettings = (settingData) => {
break; break;
case 'range': case 'range':
case 'special_range': case 'special_range':
newSettings[game][gameSetting][setting.min] = 0;
newSettings[game][gameSetting][setting.max] = 0;
newSettings[game][gameSetting]['random'] = 0; newSettings[game][gameSetting]['random'] = 0;
newSettings[game][gameSetting]['random-low'] = 0; newSettings[game][gameSetting]['random-low'] = 0;
newSettings[game][gameSetting]['random-high'] = 0; newSettings[game][gameSetting]['random-high'] = 0;
@ -296,33 +294,33 @@ const buildWeightedSettingsDiv = (game, settings) => {
if (((setting.max - setting.min) + 1) < 11) { if (((setting.max - setting.min) + 1) < 11) {
for (let i=setting.min; i <= setting.max; ++i) { for (let i=setting.min; i <= setting.max; ++i) {
const tr = document.createElement('tr'); const tr = document.createElement('tr');
const tdLeft = document.createElement('td'); const tdLeft = document.createElement('td');
tdLeft.classList.add('td-left'); tdLeft.classList.add('td-left');
tdLeft.innerText = i; tdLeft.innerText = i;
tr.appendChild(tdLeft); tr.appendChild(tdLeft);
const tdMiddle = document.createElement('td'); const tdMiddle = document.createElement('td');
tdMiddle.classList.add('td-middle'); tdMiddle.classList.add('td-middle');
const range = document.createElement('input'); const range = document.createElement('input');
range.setAttribute('type', 'range'); range.setAttribute('type', 'range');
range.setAttribute('id', `${game}-${settingName}-${i}-range`); range.setAttribute('id', `${game}-${settingName}-${i}-range`);
range.setAttribute('data-game', game); range.setAttribute('data-game', game);
range.setAttribute('data-setting', settingName); range.setAttribute('data-setting', settingName);
range.setAttribute('data-option', i); range.setAttribute('data-option', i);
range.setAttribute('min', 0); range.setAttribute('min', 0);
range.setAttribute('max', 50); range.setAttribute('max', 50);
range.addEventListener('change', updateGameSetting); range.addEventListener('change', updateGameSetting);
range.value = currentSettings[game][settingName][i]; range.value = currentSettings[game][settingName][i] || 0;
tdMiddle.appendChild(range); tdMiddle.appendChild(range);
tr.appendChild(tdMiddle); tr.appendChild(tdMiddle);
const tdRight = document.createElement('td'); const tdRight = document.createElement('td');
tdRight.setAttribute('id', `${game}-${settingName}-${i}`) tdRight.setAttribute('id', `${game}-${settingName}-${i}`)
tdRight.classList.add('td-right'); tdRight.classList.add('td-right');
tdRight.innerText = range.value; tdRight.innerText = range.value;
tr.appendChild(tdRight); tr.appendChild(tdRight);
rangeTbody.appendChild(tr); rangeTbody.appendChild(tr);
} }
} else { } else {
const hintText = document.createElement('p'); const hintText = document.createElement('p');