monorail
/
Archipelago
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rogue Legacy: Crash generation when there are overlapping IDs (#3865) 

Client literally does not work when there are overlapping IDs.

Phar is not currently intending to fix it.

https://discord.com/channels/731205301247803413/929585237695029268/1269684436853723156
This commit is contained in:
NewSoupVi 2024-09-01 21:41:55 +02:00 committed by GitHub
parent 1a41e1acc8
commit 6f46397185
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
worlds/rogue_legacy/__init__.py
View File

@ -49,6 +49,30 @@ class RLWorld(World):
return {option_name: self.get_setting(option_name).value for option_name in rl_options}
def generate_early(self):
location_ids_used_per_game = {
world.game: set(world.location_id_to_name) for world in self.multiworld.worlds.values()
}
item_ids_used_per_game = {
world.game: set(world.item_id_to_name) for world in self.multiworld.worlds.values()
}
overlapping_games = set()
for id_lookup in (location_ids_used_per_game, item_ids_used_per_game):
for game_1, ids_1 in id_lookup.items():
for game_2, ids_2 in id_lookup.items():
if game_1 == game_2:
continue
if ids_1 & ids_2:
overlapping_games.add(tuple(sorted([game_1, game_2])))
if overlapping_games:
raise RuntimeError(
"In this multiworld, there are games with overlapping item/location IDs.\n"
"The current Rogue Legacy does not support these and a fix is not currently planned.\n"
f"The overlapping games are: {overlapping_games}"
)
# Check validation of names.
additional_lady_names = len(self.get_setting("additional_lady_names").value)
additional_sir_names = len(self.get_setting("additional_sir_names").value)