From 7ab4d187afccd9377526950ec8b985f04ed3780b Mon Sep 17 00:00:00 2001 From: Fabian Dill Date: Sat, 5 Dec 2020 14:59:48 +0100 Subject: [PATCH] expand UnitTests to check for reachability with incomplete requirements --- test/TestBase.py | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/test/TestBase.py b/test/TestBase.py index df5c981f..474285f2 100644 --- a/test/TestBase.py +++ b/test/TestBase.py @@ -23,7 +23,7 @@ class TestBase(unittest.TestCase): for location, access, *item_pool in access_pool: items = item_pool[0] all_except = item_pool[1] if len(item_pool) > 1 else None - with self.subTest(location=location, access=access, items=items, all_except=all_except): + with self.subTest(msg="Reach Location", location=location, access=access, items=items, all_except=all_except): if all_except and len(all_except) > 0: items = self.world.itempool[:] items = [item for item in items if item.name not in all_except and not ("Bottle" in item.name and "AnyBottle" in all_except)] @@ -34,11 +34,23 @@ class TestBase(unittest.TestCase): self.assertEqual(self.world.get_location(location, 1).can_reach(state), access) + + #check for partial solution + if not all_except and access:# we are not supposed to be able to reach location with partial inventory + for missing_item in item_pool[0]: + with self.subTest(msg="Location reachable without required item", location=location, items=item_pool[0], + all_except=all_except, missing_item=missing_item): + new_items = item_pool[0].copy() + new_items.remove(missing_item) + items = ItemFactory(new_items, 1) + state = self.get_state(items) + self.assertEqual(self.world.get_location(location, 1).can_reach(state), False) + def run_entrance_tests(self, access_pool): for entrance, access, *item_pool in access_pool: items = item_pool[0] all_except = item_pool[1] if len(item_pool) > 1 else None - with self.subTest(entrance=entrance, access=access, items=items, all_except=all_except): + with self.subTest(msg="Reach Entrance", entrance=entrance, access=access, items=items, all_except=all_except): if all_except and len(all_except) > 0: items = self.world.itempool[:] items = [item for item in items if item.name not in all_except and not ("Bottle" in item.name and "AnyBottle" in all_except)] @@ -47,4 +59,15 @@ class TestBase(unittest.TestCase): items = ItemFactory(items, 1) state = self.get_state(items) - self.assertEqual(self.world.get_entrance(entrance, 1).can_reach(state), access) \ No newline at end of file + self.assertEqual(self.world.get_entrance(entrance, 1).can_reach(state), access) + + #check for partial solution + if not all_except and access:# we are not supposed to be able to reach location with partial inventory + for missing_item in item_pool[0]: + with self.subTest(msg="Entrance reachable without required item", entrance=entrance, items=item_pool[0], + all_except=all_except, missing_item=missing_item): + new_items = item_pool[0].copy() + new_items.remove(missing_item) + items = ItemFactory(new_items, 1) + state = self.get_state(items) + self.assertEqual(self.world.get_entrance(entrance, 1).can_reach(state), False) \ No newline at end of file