From 7ec37d99fb43e8e1dee754c55ecc13781342cb65 Mon Sep 17 00:00:00 2001 From: Fabian Dill Date: Tue, 25 Aug 2020 20:20:36 +0200 Subject: [PATCH] only iterate of the item pool once for retro replacements --- ItemPool.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ItemPool.py b/ItemPool.py index ea01a596..5bd16173 100644 --- a/ItemPool.py +++ b/ItemPool.py @@ -658,10 +658,8 @@ def get_pool_core(world, player: int): pool.remove("Rupees (20)") if retro: - pool = [item.replace('Single Arrow', 'Rupees (5)') for item in pool] - pool = [item.replace('Arrows (10)', 'Rupees (5)') for item in pool] - pool = [item.replace('Arrow Upgrade (+5)', 'Rupees (5)') for item in pool] - pool = [item.replace('Arrow Upgrade (+10)', 'Rupees (5)') for item in pool] + replace = {'Single Arrow', 'Arrows (10)', 'Arrow Upgrade (+5)', 'Arrow Upgrade (+10)'} + pool = ['Rupees (5)' if item in replace else item for item in pool] if world.keyshuffle[player] == "universal": pool.extend(diff.universal_keys) if mode == 'standard':