monorail
/
Archipelago
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Options: more feedback on bad compares (#362)

This commit is contained in:
Fabian Dill 2022-03-31 03:29:45 +02:00 committed by GitHub
parent 0263130126
commit 8337689640
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Options.py
View File

@ -180,10 +180,10 @@ class Choice(Option[int]):
if isinstance(other, self.__class__): if isinstance(other, self.__class__):
return other.value == self.value return other.value == self.value
elif isinstance(other, str): elif isinstance(other, str):
assert other in self.options, "compared against a str that could never be equal." assert other in self.options, f"compared against a str that could never be equal. {self} == {other}"
return other == self.current_key return other == self.current_key
elif isinstance(other, int): elif isinstance(other, int):
assert other in self.name_lookup, "compared against an int that could never be equal." assert other in self.name_lookup, f"compared against an int that could never be equal. {self} == {other}"
return other == self.value return other == self.value
elif isinstance(other, bool): elif isinstance(other, bool):
return other == bool(self.value) return other == bool(self.value)
@ -194,10 +194,10 @@ class Choice(Option[int]):
if isinstance(other, self.__class__): if isinstance(other, self.__class__):
return other.value != self.value return other.value != self.value
elif isinstance(other, str): elif isinstance(other, str):
assert other in self.options , "compared against a str that could never be equal." assert other in self.options , f"compared against a str that could never be equal. {self} != {other}"
return other != self.current_key return other != self.current_key
elif isinstance(other, int): elif isinstance(other, int):
assert other in self.name_lookup, "compared against am int that could never be equal." assert other in self.name_lookup, f"compared against am int that could never be equal. {self} != {other}"
return other != self.value return other != self.value
elif isinstance(other, bool): elif isinstance(other, bool):
return other != bool(self.value) return other != bool(self.value)