monorail
/
Archipelago
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Test: explicitly make sure there is no double use of location Name or ID (#1605)

This commit is contained in:
Fabian Dill 2023-03-27 01:04:13 +02:00 committed by GitHub
parent e2c4293a6d
commit 90813c0f4b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/general/TestLocations.py
View File

@ -6,13 +6,19 @@ from . import setup_solo_multiworld
class TestBase(unittest.TestCase): class TestBase(unittest.TestCase):
def testCreateDuplicateLocations(self): def testCreateDuplicateLocations(self):
"""Tests that no two Locations share a name.""" """Tests that no two Locations share a name or ID."""
for game_name, world_type in AutoWorldRegister.world_types.items(): for game_name, world_type in AutoWorldRegister.world_types.items():
multiworld = setup_solo_multiworld(world_type) multiworld = setup_solo_multiworld(world_type)
locations = Counter(multiworld.get_locations()) locations = Counter(location.name for location in multiworld.get_locations())
if locations: if locations:
self.assertLessEqual(locations.most_common(1)[0][1], 1, self.assertLessEqual(locations.most_common(1)[0][1], 1,
f"{world_type.game} has duplicate of location {locations.most_common(1)}") f"{world_type.game} has duplicate of location name {locations.most_common(1)}")
locations = Counter(location.address for location in multiworld.get_locations()
if type(location.address) is int)
if locations:
self.assertLessEqual(locations.most_common(1)[0][1], 1,
f"{world_type.game} has duplicate of location ID {locations.most_common(1)}")
def testLocationsInDatapackage(self): def testLocationsInDatapackage(self):
"""Tests that created locations not filled before fill starts exist in the datapackage.""" """Tests that created locations not filled before fill starts exist in the datapackage."""