monorail
/
Archipelago
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Core: Log warnings at call site, not Utils itself (#4229)

This commit is contained in:
Benjamin S Wolf 2024-11-29 11:40:02 -08:00 committed by GitHub
parent 05aa96a335
commit d36c983461
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Utils.py
View File

@ -858,11 +858,10 @@ def async_start(co: Coroutine[None, None, typing.Any], name: Optional[str] = Non
task.add_done_callback(_faf_tasks.discard) task.add_done_callback(_faf_tasks.discard)
def deprecate(message: str): def deprecate(message: str, add_stacklevels: int = 0):
if __debug__: if __debug__:
raise Exception(message) raise Exception(message)
import warnings warnings.warn(message, stacklevel=2 + add_stacklevels)
warnings.warn(message)
class DeprecateDict(dict): class DeprecateDict(dict):
@ -876,10 +875,9 @@ class DeprecateDict(dict):
def __getitem__(self, item: Any) -> Any: def __getitem__(self, item: Any) -> Any:
if self.should_error: if self.should_error:
deprecate(self.log_message) deprecate(self.log_message, add_stacklevels=1)
elif __debug__: elif __debug__:
import warnings warnings.warn(self.log_message, stacklevel=2)
warnings.warn(self.log_message)
return super().__getitem__(item) return super().__getitem__(item)