Test: check for working completion condition

test/general/TestImplemented.py

@@ -0,0 +1,14 @@
+import unittest
+from worlds.AutoWorld import AutoWorldRegister, World
+
+from . import setup_default_world
+
+
+class TestIDs(unittest.TestCase):
+    def testCompletionCondition(self):
+        """Ensure a completion condition is set that has requirements."""
+        for gamename, world_type in AutoWorldRegister.world_types.items():
+            if not world_type.hidden and gamename not in {"ArchipIDLE", "Final Fantasy"}:
+                with self.subTest(gamename):
+                    world = setup_default_world(world_type)
+                    self.assertFalse(world.completion_condition[1](world.state))

test/general/__init__.py

@@ -1,12 +1,12 @@
 from argparse import Namespace
 
-from BaseClasses import MultiWorld, CollectionState
+from BaseClasses import MultiWorld
 from worlds.AutoWorld import call_all
 
 gen_steps = ["generate_early", "create_regions", "create_items", "set_rules", "generate_basic", "pre_fill"]
 
 
-def setup_default_world(world_type):
+def setup_default_world(world_type) -> MultiWorld:
     world = MultiWorld(1)
     world.game[1] = world_type.game
     world.player_name = {1: "Tester"}