monorail
/
Archipelago
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DS3: Don't return early in the location loop (#3856) 

This caused behavior errors when some locations in a group were
excluded and others were not.
This commit is contained in:
Natalie Weizenbaum 2024-08-31 04:44:09 -07:00 committed by GitHub
parent 8ed466bf24
commit f81335d614
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
worlds/dark_souls_3/__init__.py
View File

@ -1292,10 +1292,10 @@ class DarkSouls3World(World):
locations = location if isinstance(location, list) else [location] locations = location if isinstance(location, list) else [location]
for location in locations: for location in locations:
data = location_dictionary[location] data = location_dictionary[location]
if data.dlc and not self.options.enable_dlc: return if data.dlc and not self.options.enable_dlc: continue
if data.ngp and not self.options.enable_ngp: return if data.ngp and not self.options.enable_ngp: continue
if not self._is_location_available(location): return if not self._is_location_available(location): continue
if isinstance(rule, str): if isinstance(rule, str):
assert item_dictionary[rule].classification == ItemClassification.progression assert item_dictionary[rule].classification == ItemClassification.progression
rule = lambda state, item=rule: state.has(item, self.player) rule = lambda state, item=rule: state.has(item, self.player)