monorail
/
Archipelago
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core: properly declare from_any as an abstract classmethod

This commit is contained in:
el-u 2023-01-31 21:26:09 +01:00 committed by Fabian Dill
parent dc2aa5f41e
commit ffff9ece55
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Options.py
View File

@ -79,9 +79,6 @@ class AssembleOptions(abc.ABCMeta):
return super(AssembleOptions, mcs).__new__(mcs, name, bases, attrs) return super(AssembleOptions, mcs).__new__(mcs, name, bases, attrs)
@abc.abstractclassmethod
def from_any(cls, value: typing.Any) -> "Option[typing.Any]": ...
T = typing.TypeVar('T') T = typing.TypeVar('T')
@ -129,8 +126,9 @@ class Option(typing.Generic[T], metaclass=AssembleOptions):
return bool(self.value) return bool(self.value)
@classmethod @classmethod
@abc.abstractmethod
def from_any(cls, data: typing.Any) -> Option[T]: def from_any(cls, data: typing.Any) -> Option[T]:
raise NotImplementedError ...
if typing.TYPE_CHECKING: if typing.TYPE_CHECKING:
from Generate import PlandoOptions from Generate import PlandoOptions
@ -168,7 +166,7 @@ class FreeText(Option):
return value return value
class NumericOption(Option[int], numbers.Integral): class NumericOption(Option[int], numbers.Integral, abc.ABC):
default = 0 default = 0
# note: some of the `typing.Any`` here is a result of unresolved issue in python standards # note: some of the `typing.Any`` here is a result of unresolved issue in python standards
# `int` is not a `numbers.Integral` according to the official typestubs # `int` is not a `numbers.Integral` according to the official typestubs