Updated all self._url variables to use format.

This commit is contained in:
2018-03-03 20:41:33 -05:00
parent 5460d2b676
commit 7ad802bcd8
6 changed files with 18 additions and 5 deletions

View File

@ -1,22 +1,35 @@
# Changelog
## 1.3.4
Changes
- Updates all the classes for readability and DRYness.
## 1.3.0 ## 1.3.0
New Stuff New Stuff
- Scrython now uses the threading module to allow for discord.py implementations. - Scrython now uses the threading module to allow for discord.py implementations.
Changes Changes
- Added `power()`, `toughness()`, and `flavor_text()` attributes to cards_object. Thanks to Mendess2526! - Added `power()`, `toughness()`, and `flavor_text()` attributes to cards_object. Thanks to Mendess2526!
Bugfixes Bugfixes
- Fixed a bug that would prevent you from creating a cards.Autocomplete() object. - Fixed a bug that would prevent you from creating a cards.Autocomplete() object.
## 1.2.0 ## 1.2.0
New Stuff New Stuff
- Created this doc for everyone to keep track of changes to this library. - Created this doc for everyone to keep track of changes to this library.
- All classes now have a docstring. - All classes now have a docstring.
- Created an example script for checking cards in a .csv - Created an example script for checking cards in a .csv
Changes Changes
- cards.Autocomplete() has had the `q` parameter updated to `query`. - cards.Autocomplete() has had the `q` parameter updated to `query`.
- symbology.Parsemana() now has a required parameter of `code`. - symbology.Parsemana() now has a required parameter of `code`.
- Updated the README with more information, and better organization. - Updated the README with more information, and better organization.

View File

@ -81,7 +81,7 @@ class CardsObject(object):
} }
self.encodedParams = urllib.parse.urlencode(self.params) self.encodedParams = urllib.parse.urlencode(self.params)
self._url = 'https://api.scryfall.com/' + _url + "&" + self.encodedParams self._url = 'https://api.scryfall.com/{0}&{1}'.format(_url, self.encodedParams)
async def getRequest(client, url, **kwargs): async def getRequest(client, url, **kwargs):
async with client.get(url, **kwargs) as response: async with client.get(url, **kwargs) as response:

View File

@ -24,7 +24,7 @@ class CatalogsObject(object):
self.params = {'format': kwargs.get('format', 'json'), 'pretty': kwargs.get('pretty', '')} self.params = {'format': kwargs.get('format', 'json'), 'pretty': kwargs.get('pretty', '')}
self.encodedParams = urllib.parse.urlencode(self.params) self.encodedParams = urllib.parse.urlencode(self.params)
self._url = 'https://api.scryfall.com/' + _url + "&" + self.encodedParams #Find a fix for this later self._url = 'https://api.scryfall.com/{0}&{1}'.format(_url, self.encodedParams)
async def getRequest(client, url, **kwargs): async def getRequest(client, url, **kwargs):
async with client.get(url, **kwargs) as response: async with client.get(url, **kwargs) as response:

View File

@ -38,7 +38,7 @@ class RulingsObject(object):
} }
self.encodedParams = urllib.parse.urlencode(self.params) self.encodedParams = urllib.parse.urlencode(self.params)
self._url = 'https://api.scryfall.com/' + _url + "&" + self.encodedParams #Find a fix for this later self._url = 'https://api.scryfall.com/{0}&{1}'.format(_url, self.encodedParams)
async def getRequest(client, url, **kwargs): async def getRequest(client, url, **kwargs):
async with client.get(url, **kwargs) as response: async with client.get(url, **kwargs) as response:

View File

@ -34,7 +34,7 @@ class SetsObject(object):
self.params = {'format': kwargs.get('format', 'json'), 'pretty': kwargs.get('pretty', '')} self.params = {'format': kwargs.get('format', 'json'), 'pretty': kwargs.get('pretty', '')}
self.encodedParams = urllib.parse.urlencode(self.params) self.encodedParams = urllib.parse.urlencode(self.params)
self._url = 'https://api.scryfall.com/' + _url + "&" + self.encodedParams #Find a fix for this later self._url = 'https://api.scryfall.com/{0}&{1}'.format(_url, self.encodedParams)
async def getRequest(client, url, **kwargs): async def getRequest(client, url, **kwargs):
async with client.get(url, **kwargs) as response: async with client.get(url, **kwargs) as response:

View File

@ -21,7 +21,7 @@ class SymbologyObject(object):
self.params = {'format': kwargs.get('format', 'json'), 'pretty': kwargs.get('pretty', '')} self.params = {'format': kwargs.get('format', 'json'), 'pretty': kwargs.get('pretty', '')}
self.encodedParams = urllib.parse.urlencode(self.params) self.encodedParams = urllib.parse.urlencode(self.params)
self._url = 'https://api.scryfall.com/' + _url + "&" + self.encodedParams #Find a fix for this later self._url = 'https://api.scryfall.com/{0}&{1}'.format(_url, self.encodedParams)
async def getRequest(client, url, **kwargs): async def getRequest(client, url, **kwargs):
async with client.get(url, **kwargs) as response: async with client.get(url, **kwargs) as response: