From b625f0a5fd463024b10ead23dcf37c4e8521657c Mon Sep 17 00:00:00 2001 From: Katelyn Gigante Date: Tue, 9 Jun 2020 13:48:40 +1000 Subject: [PATCH] Bulk data was renamed --- scrython/bulk_data/bulk_data.py | 9 +++++++-- unittests/test_bulk.py | 4 ++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/scrython/bulk_data/bulk_data.py b/scrython/bulk_data/bulk_data.py index ec61638..d3c4478 100644 --- a/scrython/bulk_data/bulk_data.py +++ b/scrython/bulk_data/bulk_data.py @@ -5,6 +5,7 @@ import asyncio import aiohttp import urllib.parse from threading import Thread +import warnings class BulkData(FoundationObject): """ @@ -164,6 +165,10 @@ class BulkData(FoundationObject): return self.scryfallJson['data'][num]['compressed_size'] def bulk_permalink_uri(self, num): + warnings.warn("This method has been renamed to bulk_uri as per https://scryfall.com/blog/updates-to-bulk-data-and-cards-deprecation-notice-217", DeprecationWarning) + return self.bulk_uri(num) + + def bulk_uri(self, num): """The URL that hosts the bulk file Args: @@ -172,9 +177,9 @@ class BulkData(FoundationObject): Returns: string: A URI to download the compressed data """ - super(BulkData, self)._checkForTupleKey('data', num, 'permalink_uri') + super(BulkData, self)._checkForTupleKey('data', num, 'uri') - return self.scryfallJson['data'][num]['permalink_uri'] + return self.scryfallJson['data'][num]['uri'] def bulk_content_type(self, num): """The MIME type of the file diff --git a/unittests/test_bulk.py b/unittests/test_bulk.py index c1a10c8..f6bcdfa 100644 --- a/unittests/test_bulk.py +++ b/unittests/test_bulk.py @@ -41,8 +41,8 @@ class TestBulk(unittest.TestCase): self.assertIsInstance(bulk.bulk_compressed_size(0), int) self.assertIsInstance(bulk.bulk_compressed_size(0, True), str) - def test_bulk_permalink_uri(self): - self.assertIsInstance(bulk.bulk_permalink_uri(0), str) + def test_bulk_uri(self): + self.assertIsInstance(bulk.bulk_uri(0), str) def test_bulk_content_type(self): self.assertIsInstance(bulk.bulk_content_type(0), str)