monorail
/
mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix glitch local settings navigation items not being proper buttons (#2320)

This commit is contained in:
Claire 2023-07-23 14:31:16 +02:00 committed by GitHub
parent dd09535bda
commit 49767d20bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/javascript/flavours/glitch/features/local_settings/navigation/item/index.jsx
View File

@ -58,16 +58,14 @@ export default class LocalSettingsPage extends PureComponent {
</a> </a>
); );
else if (onNavigate) return ( else if (onNavigate) return (
<a <button
onClick={handleClick} onClick={handleClick}
role='button'
tabIndex={0}
className={finalClassName} className={finalClassName}
title={title} title={title}
aria-label={title} aria-label={title}
> >
{iconElem} <span>{title}</span> {iconElem} <span>{title}</span>
</a> </button>
); );
else return null; else return null;
} }

5
app/javascript/flavours/glitch/styles/components/local_settings.scss
View File

@ -56,11 +56,16 @@
padding: 15px 20px; padding: 15px 20px;
color: inherit; color: inherit;
background: lighten($ui-secondary-color, 8%); background: lighten($ui-secondary-color, 8%);
border: 0;
border-bottom: 1px $ui-secondary-color solid; border-bottom: 1px $ui-secondary-color solid;
cursor: pointer; cursor: pointer;
text-decoration: none; text-decoration: none;
outline: none; outline: none;
transition: background 0.3s; transition: background 0.3s;
box-sizing: border-box;
width: 100%;
text-align: start;
font-size: inherit;
.text-icon-button { .text-icon-button {
color: inherit; color: inherit;