Add shared example for CLI command specs (#28165)

spec/lib/mastodon/cli/accounts_spec.rb

@@ -6,6 +6,8 @@ require 'mastodon/cli/accounts'
 describe Mastodon::CLI::Accounts do
   let(:cli) { described_class.new }
 
+  it_behaves_like 'CLI Command'
+
   # `parallelize_with_progress` cannot run in transactions, so instead,
   # stub it with an alternative implementation that runs sequentially
   # and can run in transactions.
@@ -24,12 +26,6 @@ describe Mastodon::CLI::Accounts do
     end
   end
 
-  describe '.exit_on_failure?' do
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
-
   describe '#create' do
     shared_examples 'a new user with given email address and username' do
       it 'creates a new user with the specified email address' do

spec/lib/mastodon/cli/cache_spec.rb

@@ -6,11 +6,7 @@ require 'mastodon/cli/cache'
 describe Mastodon::CLI::Cache do
   let(:cli) { described_class.new }
 
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe '#clear' do
     before { allow(Rails.cache).to receive(:clear) }

spec/lib/mastodon/cli/canonical_email_blocks_spec.rb

@@ -6,11 +6,7 @@ require 'mastodon/cli/canonical_email_blocks'
 describe Mastodon::CLI::CanonicalEmailBlocks do
   let(:cli) { described_class.new }
 
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe '#find' do
     let(:arguments) { ['user@example.com'] }

spec/lib/mastodon/cli/domains_spec.rb

@@ -4,9 +4,5 @@ require 'rails_helper'
 require 'mastodon/cli/domains'
 
 describe Mastodon::CLI::Domains do
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 end

spec/lib/mastodon/cli/email_domain_blocks_spec.rb

@@ -4,9 +4,5 @@ require 'rails_helper'
 require 'mastodon/cli/email_domain_blocks'
 
 describe Mastodon::CLI::EmailDomainBlocks do
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 end

spec/lib/mastodon/cli/emoji_spec.rb

@@ -4,9 +4,5 @@ require 'rails_helper'
 require 'mastodon/cli/emoji'
 
 describe Mastodon::CLI::Emoji do
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 end

spec/lib/mastodon/cli/feeds_spec.rb

@@ -6,11 +6,7 @@ require 'mastodon/cli/feeds'
 describe Mastodon::CLI::Feeds do
   let(:cli) { described_class.new }
 
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe '#build' do
     before { Fabricate(:account) }

spec/lib/mastodon/cli/ip_blocks_spec.rb

@@ -6,11 +6,7 @@ require 'mastodon/cli/ip_blocks'
 describe Mastodon::CLI::IpBlocks do
   let(:cli) { described_class.new }
 
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe '#add' do
     let(:ip_list) do

spec/lib/mastodon/cli/main_spec.rb

@@ -4,11 +4,7 @@ require 'rails_helper'
 require 'mastodon/cli/main'
 
 describe Mastodon::CLI::Main do
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe 'version' do
     it 'returns the Mastodon version' do

spec/lib/mastodon/cli/maintenance_spec.rb

@@ -6,11 +6,7 @@ require 'mastodon/cli/maintenance'
 describe Mastodon::CLI::Maintenance do
   let(:cli) { described_class.new }
 
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe '#fix_duplicates' do
     context 'when the database version is too old' do

spec/lib/mastodon/cli/media_spec.rb

@@ -6,11 +6,7 @@ require 'mastodon/cli/media'
 describe Mastodon::CLI::Media do
   let(:cli) { described_class.new }
 
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe '#remove' do
     context 'with --prune-profiles and --remove-headers' do

spec/lib/mastodon/cli/preview_cards_spec.rb

@@ -6,11 +6,7 @@ require 'mastodon/cli/preview_cards'
 describe Mastodon::CLI::PreviewCards do
   let(:cli) { described_class.new }
 
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe '#remove' do
     context 'with relevant preview cards' do

spec/lib/mastodon/cli/search_spec.rb

@@ -4,9 +4,5 @@ require 'rails_helper'
 require 'mastodon/cli/search'
 
 describe Mastodon::CLI::Search do
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 end

spec/lib/mastodon/cli/settings_spec.rb

@@ -4,11 +4,7 @@ require 'rails_helper'
 require 'mastodon/cli/settings'
 
 describe Mastodon::CLI::Settings do
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe 'subcommand "registrations"' do
     let(:cli) { Mastodon::CLI::Registrations.new }

spec/lib/mastodon/cli/statuses_spec.rb

@@ -6,11 +6,7 @@ require 'mastodon/cli/statuses'
 describe Mastodon::CLI::Statuses do
   let(:cli) { described_class.new }
 
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 
   describe '#remove', use_transactional_tests: false do
     context 'with small batch size' do

spec/lib/mastodon/cli/upgrade_spec.rb

@@ -4,9 +4,5 @@ require 'rails_helper'
 require 'mastodon/cli/upgrade'
 
 describe Mastodon::CLI::Upgrade do
-  describe '.exit_on_failure?' do
+  it_behaves_like 'CLI Command'
-    it 'returns true' do
-      expect(described_class.exit_on_failure?).to be true
-    end
-  end
 end

spec/support/examples/cli.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+shared_examples 'CLI Command' do
+  it 'configures Thor to exit on failure' do
+    expect(described_class.exit_on_failure?).to be true
+  end
+
+  it 'descends from the CLI base class' do
+    expect(described_class.new).to be_a(Mastodon::CLI::Base)
+  end
+end