monorail
/
mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Convert `api/v2/search` controller spec to request spec (#28269)

This commit is contained in:
Matt Jankowski 2023-12-08 04:27:33 -05:00 committed by GitHub
parent 8d8ae05a18
commit 7e514688b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
spec/controllers/api/v2/search_controller_spec.rb → spec/requests/api/v2/search_spec.rb
View File

@ -2,25 +2,21 @@
require 'rails_helper' require 'rails_helper'
RSpec.describe Api::V2::SearchController do describe 'Search API' do
render_views
context 'with token' do context 'with token' do
let(:user) { Fabricate(:user) } let(:user) { Fabricate(:user) }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read:search') } let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
let(:scopes) { 'read:search' }
let(:headers) { { 'Authorization' => "Bearer #{token.token}" } }
before do describe 'GET /api/v2/search' do
allow(controller).to receive(:doorkeeper_token) { token }
end
describe 'GET #index' do
let!(:bob) { Fabricate(:account, username: 'bob_test') } let!(:bob) { Fabricate(:account, username: 'bob_test') }
let!(:ana) { Fabricate(:account, username: 'ana_test') } let!(:ana) { Fabricate(:account, username: 'ana_test') }
let!(:tom) { Fabricate(:account, username: 'tom_test') } let!(:tom) { Fabricate(:account, username: 'tom_test') }
let(:params) { { q: 'test' } } let(:params) { { q: 'test' } }
it 'returns http success' do it 'returns http success' do
get :index, params: params get '/api/v2/search', headers: headers, params: params
expect(response).to have_http_status(200) expect(response).to have_http_status(200)
end end
@ -29,7 +25,7 @@ RSpec.describe Api::V2::SearchController do
let(:params) { { q: 'test', type: 'accounts' } } let(:params) { { q: 'test', type: 'accounts' } }
it 'returns all matching accounts' do it 'returns all matching accounts' do
get :index, params: params get '/api/v2/search', headers: headers, params: params
expect(body_as_json[:accounts].pluck(:id)).to contain_exactly(bob.id.to_s, ana.id.to_s, tom.id.to_s) expect(body_as_json[:accounts].pluck(:id)).to contain_exactly(bob.id.to_s, ana.id.to_s, tom.id.to_s)
end end
@ -38,7 +34,7 @@ RSpec.describe Api::V2::SearchController do
let(:params) { { q: 'test1', resolve: '1' } } let(:params) { { q: 'test1', resolve: '1' } }
it 'returns http unauthorized' do it 'returns http unauthorized' do
get :index, params: params get '/api/v2/search', headers: headers, params: params
expect(response).to have_http_status(200) expect(response).to have_http_status(200)
end end
@ -48,7 +44,7 @@ RSpec.describe Api::V2::SearchController do
let(:params) { { q: 'test1', offset: 1 } } let(:params) { { q: 'test1', offset: 1 } }
it 'returns http unauthorized' do it 'returns http unauthorized' do
get :index, params: params get '/api/v2/search', headers: headers, params: params
expect(response).to have_http_status(200) expect(response).to have_http_status(200)
end end
@ -62,7 +58,7 @@ RSpec.describe Api::V2::SearchController do
end end
it 'returns only the followed accounts' do it 'returns only the followed accounts' do
get :index, params: params get '/api/v2/search', headers: headers, params: params
expect(body_as_json[:accounts].pluck(:id)).to contain_exactly(ana.id.to_s) expect(body_as_json[:accounts].pluck(:id)).to contain_exactly(ana.id.to_s)
end end
@ -73,7 +69,7 @@ RSpec.describe Api::V2::SearchController do
before { allow(Search).to receive(:new).and_raise(Mastodon::SyntaxError) } before { allow(Search).to receive(:new).and_raise(Mastodon::SyntaxError) }
it 'returns http unprocessable_entity' do it 'returns http unprocessable_entity' do
get :index, params: params get '/api/v2/search', headers: headers, params: params
expect(response).to have_http_status(422) expect(response).to have_http_status(422)
end end
@ -83,7 +79,7 @@ RSpec.describe Api::V2::SearchController do
before { allow(Search).to receive(:new).and_raise(ActiveRecord::RecordNotFound) } before { allow(Search).to receive(:new).and_raise(ActiveRecord::RecordNotFound) }
it 'returns http not_found' do it 'returns http not_found' do
get :index, params: params get '/api/v2/search', headers: headers, params: params
expect(response).to have_http_status(404) expect(response).to have_http_status(404)
end end
@ -92,11 +88,11 @@ RSpec.describe Api::V2::SearchController do
end end
context 'without token' do context 'without token' do
describe 'GET #index' do describe 'GET /api/v2/search' do
let(:search_params) { nil } let(:search_params) { nil }
before do before do
get :index, params: search_params get '/api/v2/search', params: search_params
end end
context 'without a `q` param' do context 'without a `q` param' do