From 64154c5161d4d5c82877fba549d72068cc7f9e16 Mon Sep 17 00:00:00 2001 From: "Brian C. Lindner" Date: Sun, 31 May 2020 14:34:34 -0400 Subject: [PATCH 1/4] Allow Ctrl-click to keep EmojiPicker window open (#13896) --- .../features/compose/components/emoji_picker_dropdown.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js b/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js index 582bb0d39c..a6186010b4 100644 --- a/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js +++ b/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js @@ -199,12 +199,13 @@ class EmojiPickerMenu extends React.PureComponent { }; } - handleClick = emoji => { + handleClick = (emoji, event) => { if (!emoji.native) { emoji.native = emoji.colons; } - - this.props.onClose(); + if (!event.ctrlKey) { + this.props.onClose(); + } this.props.onPick(emoji); } From b4a8400afd88a2ae8822757e5d30975494be2512 Mon Sep 17 00:00:00 2001 From: Christopher Choi Date: Sun, 31 May 2020 11:35:18 -0700 Subject: [PATCH 2/4] Adjust flash alert contrast for better readability (#13892) --- app/javascript/styles/mastodon/forms.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/javascript/styles/mastodon/forms.scss b/app/javascript/styles/mastodon/forms.scss index 0e5b00e8f1..7a0b2f9a39 100644 --- a/app/javascript/styles/mastodon/forms.scss +++ b/app/javascript/styles/mastodon/forms.scss @@ -587,7 +587,7 @@ code { &.alert { border: 1px solid rgba($error-value-color, 0.5); - background: rgba($error-value-color, 0.25); + background: rgba($error-value-color, 0.1); color: $error-value-color; } From eeddb1a624c0e743e3e7b6d35104adfb10f2a747 Mon Sep 17 00:00:00 2001 From: ThibG Date: Sun, 31 May 2020 20:38:56 +0200 Subject: [PATCH 3/4] Fix unsent toot confirmation dialog not popping up in single column (#13888) --- .../features/ui/components/compose_panel.js | 38 ++++++++++++++----- app/javascript/mastodon/features/ui/index.js | 1 + 2 files changed, 30 insertions(+), 9 deletions(-) diff --git a/app/javascript/mastodon/features/ui/components/compose_panel.js b/app/javascript/mastodon/features/ui/components/compose_panel.js index c7821f473a..3d0c48c7a9 100644 --- a/app/javascript/mastodon/features/ui/components/compose_panel.js +++ b/app/javascript/mastodon/features/ui/components/compose_panel.js @@ -1,16 +1,36 @@ import React from 'react'; +import { connect } from 'react-redux'; +import PropTypes from 'prop-types'; import SearchContainer from 'mastodon/features/compose/containers/search_container'; import ComposeFormContainer from 'mastodon/features/compose/containers/compose_form_container'; import NavigationContainer from 'mastodon/features/compose/containers/navigation_container'; import LinkFooter from './link_footer'; +import { changeComposing } from 'mastodon/actions/compose'; -const ComposePanel = () => ( -
- - - - -
-); +export default @connect() +class ComposePanel extends React.PureComponent { -export default ComposePanel; + static propTypes = { + dispatch: PropTypes.func.isRequired, + }; + + onFocus = () => { + this.props.dispatch(changeComposing(true)); + } + + onBlur = () => { + this.props.dispatch(changeComposing(false)); + } + + render() { + return ( +
+ + + + +
+ ); + } + +} diff --git a/app/javascript/mastodon/features/ui/index.js b/app/javascript/mastodon/features/ui/index.js index 81ffad22ed..d21ecf2088 100644 --- a/app/javascript/mastodon/features/ui/index.js +++ b/app/javascript/mastodon/features/ui/index.js @@ -254,6 +254,7 @@ class UI extends React.PureComponent { dispatch(synchronouslySubmitMarkers()); if (isComposing && (hasComposingText || hasMediaAttachments)) { + e.preventDefault(); // Setting returnValue to any string causes confirmation dialog. // Many browsers no longer display this text to users, // but we set user-friendly message for other browsers, e.g. Edge. From 51ff679b9deb559ddc53cdfa6265b996f6c7fd5e Mon Sep 17 00:00:00 2001 From: ThibG Date: Mon, 1 Jun 2020 03:47:20 +0200 Subject: [PATCH 4/4] Fix admin page crashing when trying to block an invalid domain name (#13884) * Fix admin page crashing when trying to block an invalid domain name Fixes #13880 * Fix trailing and leading spaces not being properly stripped for domain blocks --- app/models/concerns/domain_normalizable.rb | 2 +- app/models/domain_block.rb | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/models/concerns/domain_normalizable.rb b/app/models/concerns/domain_normalizable.rb index c00b3142fa..fb84058fc2 100644 --- a/app/models/concerns/domain_normalizable.rb +++ b/app/models/concerns/domain_normalizable.rb @@ -4,7 +4,7 @@ module DomainNormalizable extend ActiveSupport::Concern included do - before_save :normalize_domain + before_validation :normalize_domain end private diff --git a/app/models/domain_block.rb b/app/models/domain_block.rb index f0a5bd296b..2b18e01fad 100644 --- a/app/models/domain_block.rb +++ b/app/models/domain_block.rb @@ -50,11 +50,13 @@ class DomainBlock < ApplicationRecord def rule_for(domain) return if domain.blank? - uri = Addressable::URI.new.tap { |u| u.host = domain.gsub(/[\/]/, '') } + uri = Addressable::URI.new.tap { |u| u.host = domain.strip.gsub(/[\/]/, '') } segments = uri.normalized_host.split('.') variants = segments.map.with_index { |_, i| segments[i..-1].join('.') } where(domain: variants).order(Arel.sql('char_length(domain) desc')).first + rescue Addressable::URI::InvalidURIError, IDN::Idna::IdnaError + nil end end