monorail
/
mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove href attribute of invalid links instead of crashing

This commit is contained in:
Thibaut Girka 2019-08-06 11:31:28 +02:00 committed by ThibG
parent 0aee74d78a
commit cbd75fe128
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/javascript/flavours/glitch/components/status_content.js
View File

@ -106,6 +106,7 @@ export default class StatusContent extends React.PureComponent {
link.setAttribute('title', link.href); link.setAttribute('title', link.href);
link.classList.add('unhandled-link'); link.classList.add('unhandled-link');
try {
if (tagLinks && isLinkMisleading(link)) { if (tagLinks && isLinkMisleading(link)) {
// Add a tag besides the link to display its origin // Add a tag besides the link to display its origin
@ -115,6 +116,10 @@ export default class StatusContent extends React.PureComponent {
link.insertAdjacentText('beforeend', ' '); link.insertAdjacentText('beforeend', ' ');
link.insertAdjacentElement('beforeend', tag); link.insertAdjacentElement('beforeend', tag);
} }
} catch (TypeError) {
// Just to be safe
if (tagLinks) link.removeAttribute('href');
}
} }
link.setAttribute('target', '_blank'); link.setAttribute('target', '_blank');