monorail
/
mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix `Rails/RedundantActiveRecordAllMethod` cop (#26885)

This commit is contained in:
Matt Jankowski 2023-11-06 10:51:52 -05:00 committed by GitHub
parent 949f5eb860
commit fe26f33e0a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/lib/delivery_failure_tracker.rb
View File

@ -62,7 +62,7 @@ class DeliveryFailureTracker
key.delete_prefix(exhausted_deliveries_key_by('')) key.delete_prefix(exhausted_deliveries_key_by(''))
end end
domains - UnavailableDomain.all.pluck(:domain) domains - UnavailableDomain.pluck(:domain)
end end
def warning_domains_map(domains = nil) def warning_domains_map(domains = nil)

2
spec/lib/vacuum/imports_vacuum_spec.rb
View File

@ -13,7 +13,7 @@ RSpec.describe Vacuum::ImportsVacuum do
describe '#perform' do describe '#perform' do
it 'cleans up the expected imports' do it 'cleans up the expected imports' do
expect { subject.perform }.to change { BulkImport.all.pluck(:id) }.from([old_unconfirmed, new_unconfirmed, recent_ongoing, recent_finished, old_finished].map(&:id)).to([new_unconfirmed, recent_ongoing, recent_finished].map(&:id)) expect { subject.perform }.to change { BulkImport.pluck(:id) }.from([old_unconfirmed, new_unconfirmed, recent_ongoing, recent_finished, old_finished].map(&:id)).to([new_unconfirmed, recent_ongoing, recent_finished].map(&:id))
end end
end end
end end