Commit Graph

268 Commits

Author SHA1 Message Date
Matt Jankowski 2c6c398c60
Fix Performance/CollectionLiteralInLoop cop () 2023-05-04 05:33:55 +02:00
Matt Jankowski d9a958fcf7
Fix Performance/RedundantMerge cop () 2023-05-04 05:25:43 +02:00
Matt Jankowski 3df665fd23
Fix Lint/ConstantDefinitionInBlock cop () 2023-05-03 10:32:30 +02:00
Matt Jankowski a0c9f2447e
Fix Performance/MethodObjectAsBlock cop () 2023-05-03 10:30:54 +02:00
Matt Jankowski 97385f27bd
Fix Performance/RedundantEqualityComparisonBlock cop () 2023-05-03 10:30:10 +02:00
Matt Jankowski 668a19a2f3
Fix Performance/DeletePrefix cop () 2023-05-02 21:07:45 +02:00
Matt Jankowski 05e3abe9d9
Fix Lint/EmptyClass cop () 2023-05-02 21:06:51 +02:00
Matt Jankowski 24491abf6d
Fix Rails/DeprecatedActiveModelErrorsMethods cop () 2023-05-02 18:39:22 +02:00
Matt Jankowski b5c4b47746
Fix Rails/ActiveRecordCallbacksOrder cop () 2023-05-02 18:23:35 +02:00
Matt Jankowski 38b2974a83
Extract AccountSearch concern from Account () 2023-05-02 18:21:36 +02:00
Matt Jankowski f1c1dd0118
Rename `with_lock` to `with_redis_lock` to avoid confusion with ActiveRecord's method () 2023-05-02 18:16:07 +02:00
Matt Jankowski 570079f8ce
Fix Performance/TimesMap cop () 2023-05-02 18:07:16 +02:00
Matt Jankowski bae694108a
Fix Performance/Count cop () 2023-05-02 18:06:43 +02:00
Matt Jankowski 5e060e1f44
Fix Performance/Sum cop () 2023-05-02 16:10:40 +02:00
Matt Jankowski 88d33f361f
Fix Lint/DuplicateBranch cop () 2023-05-02 12:57:11 +02:00
Claire 32a030dd74
Rewrite import feature () 2023-05-02 12:08:48 +02:00
Matt Jankowski c53fe9b753
Fix RSpec/BeforeAfterAll cop () 2023-05-01 04:16:08 +09:00
Matt Jankowski d902a707a3
Fix Rails/CompactBlank cop () 2023-04-30 14:07:21 +02:00
Matt Jankowski d00e45a7d3
Fix Rails/I18nLocaleAssignment cop () 2023-04-30 14:07:03 +02:00
Matt Jankowski af824db398
Fix Rails/InverseOf cop () 2023-04-30 14:06:53 +02:00
Matt Jankowski 2e43461100
Fix Rails/Output cop () 2023-04-30 06:48:16 +02:00
Matt Jankowski 5a2aa06a51
Fix Rails/Present cop () 2023-04-30 06:47:50 +02:00
Matt Jankowski bdc74086e6
Fix Rails/ContentTag cop () 2023-04-30 06:47:15 +02:00
Matt Jankowski 6e226f5a32
Fix Rails/ActionOrder cop () 2023-04-30 06:46:39 +02:00
Matt Jankowski 60ac9e8634
Fix Rails/SquishedSQLHeredocs cop () 2023-04-30 06:43:50 +02:00
Matt Jankowski 8dcfb6e0ea
Fix Rails/HttpPositionalArguments cop () 2023-04-30 06:43:28 +02:00
Matt Jankowski 4cfe52635c
Add pending spec for User.those_who_can () 2023-04-29 22:03:36 +02:00
Nick Schonning 49fad26eca
Drop EOL Ruby 2.7 () 2023-04-27 01:46:18 +02:00
Nick Schonning 5841f1af8c
Autofix Rubocop RSpec/MatchArray () 2023-04-26 21:29:36 +02:00
Nick Schonning a3393d0d07
Autofix Rubocop RSpec/MatchArray () 2023-04-26 20:21:54 +02:00
Nick Schonning 90beba57d8
Autofix Rubocop Rails/ResponseParsedBody () 2023-04-26 17:25:07 +02:00
Matt Jankowski 0a5f0a8b20
Remove instance variables from helper usage () 2023-04-23 22:35:54 +02:00
Nick Schonning 4687967176
Autofix Rubocop Style/NumericLiterals () 2023-04-23 22:30:07 +02:00
Eugen Rochko e98c86050a
Refactor `Cache-Control` and `Vary` definitions () 2023-04-19 16:07:29 +02:00
Nick Schonning cb2ce842b0
Autofix Rubocop Rails/IgnoredColumnsAssignment () 2023-03-31 15:07:22 +02:00
Nick Schonning 500d6f93be
Autofix Rubocop Style/IdenticalConditionalBranches () 2023-03-31 09:33:52 +02:00
Nick Schonning 83fc97285b
Enable Rubocop Metrics/BlockLength with Excludes () 2023-03-31 09:33:25 +02:00
Eugen Rochko a9b5598c97
Change user settings to be stored in a more optimal way ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-03-30 14:44:00 +02:00
Nick Schonning 503022d6f9
Exclude files for Rubocop Metrics/ClassLength () 2023-03-23 23:19:41 +01:00
Matt Jankowski 7bef11630d
Remove references to non-existent actions () 2023-03-20 20:03:44 +01:00
Vyr Cossont 94cbd808b5
Webhooks for local status.create, status.update, account.update () 2023-03-19 07:47:54 +01:00
Nick Schonning b22b4bac03
Include config/ and update all rubcop deps () 2023-03-17 10:13:28 +01:00
Nick Schonning 681dcd3fa3
Ignore additional Style/OptionalBooleanParameter () 2023-03-16 23:07:25 +01:00
Matt Jankowski edc7ca5920
Roll back unintentionally activated rubocop rules ()
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
2023-03-16 22:24:01 +01:00
Christian Schmidt bd047acc35
Replace `Status#translatable?` with language matrix in separate endpoint () 2023-03-16 11:07:24 +01:00
Nick Schonning aa947a143b
Regen rubocop-todo without Max shadowing () 2023-03-16 12:31:08 +09:00
Nick Schonning 25d36b6edd
Autofix Rubocop Style/RedundantArgument () 2023-03-16 10:34:00 +09:00
Nick Schonning a38f67c1c3
Autofix Rubocop Style/PreferredHashMethods () 2023-03-16 01:36:37 +01:00
Nick Schonning e762a14c0a
Enable Rubocop Performance/DeleteSuffix () 2023-03-13 00:03:07 +01:00
Nick Schonning 3ea0856f70
Enable RSpec/FilePath () 2023-03-10 16:32:37 +01:00
Matt Jankowski 688287c59d
Coverage improvement round-out following up previous work () 2023-03-10 13:33:30 +01:00
Matt Jankowski 56bddfbfa3
Serializers spec coverage () 2023-03-10 12:12:51 +01:00
Claire aa98c8fbeb
Disable Style/SymbolArray () 2023-03-03 22:55:43 +01:00
Nick Schonning 56489cdc4f
Autofix Rubocop Style/HashConversion () 2023-02-28 22:59:19 +09:00
Matt Jankowski 730bb3e211
Remove unused HTML Validator () 2023-02-24 20:06:32 +01:00
Nick Schonning 19614ba247
Rename ActivityPub Serializer Specs () 2023-02-23 23:17:48 +01:00
Nick Schonning 6bd7003799
Fix mispelled spec filenames () 2023-02-23 11:28:56 +01:00
Nick Schonning 4ff44be134
Autofix Rubocop Rails/Blank () 2023-02-22 09:57:56 +09:00
Nick Schonning 8fd3fc404d
Autofix Rubocop Rails/RootPathnameMethods () 2023-02-22 09:57:15 +09:00
Nick Schonning 0cfdd1a401
Enable Rubocop Style/StringConcatenation defaults () 2023-02-22 09:54:36 +09:00
Nick Schonning 434770f580
Autofix Rubocop Rails/FindById () 2023-02-21 10:21:48 +09:00
Nick Schonning 35d032500b
Autofix Rubocop Security/IoMethods () 2023-02-21 03:21:19 +09:00
Nick Schonning 9909b4b653
Autofix Rubocop Rails/WhereEquals () 2023-02-21 03:20:56 +09:00
Nick Schonning 59c8d43d94
Autofix Rubocop Style/RescueStandardError () 2023-02-20 11:01:20 +01:00
Nick Schonning 2c3c734bcc
Autofix Rubocop Style/SymbolProc () 2023-02-20 07:58:46 +01:00
Nick Schonning af4c95100c
Autofix Rubocop Style/FormatString () 2023-02-20 07:58:33 +01:00
Nick Schonning 717683d1c3
Autofix Rubocop remaining Layout rules () 2023-02-20 06:58:28 +01:00
Nick Schonning d2dcb6c45a
Autofix Rubocop Style/UnpackFirst () 2023-02-20 06:51:43 +01:00
Nick Schonning 5116347eb7
Autofix Rubocop RSpec/BeEq () 2023-02-20 06:14:50 +01:00
Nick Schonning bf785df9fe
Audofix Rubocop Style/WordArray () 2023-02-20 06:14:10 +01:00
Nick Schonning 4552685f6b
Autofix Rubocop RSpec/LeadingSubject () 2023-02-20 13:24:14 +09:00
Nick Schonning 4ea1e0fceb
Enable Rubocop RSpec/ExpectActual () 2023-02-20 05:00:59 +01:00
Nick Schonning 38a1d8bb85
Autofix Rubocop RSpec/ImplicitSubject () 2023-02-20 05:00:48 +01:00
Nick Schonning 63e6353886
Autofix Rubocop Rails/EnumHash () 2023-02-20 05:00:36 +01:00
Nick Schonning f0e1b12c10
Autofix Rubocop Style/ExplicitBlockArgument () 2023-02-20 11:18:08 +09:00
Nick Schonning 5179c47087
Autofix Rubocops RSpec/ScatteredLet () 2023-02-20 11:17:41 +09:00
Nick Schonning aef0051fd0
Enable Rubocop HTTP status rules () 2023-02-20 11:16:40 +09:00
Nick Schonning bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject () 2023-02-20 02:46:00 +01:00
Nick Schonning dbc6d7b276
Autofix Rubocop Lint/UnusedBlockArgument () 2023-02-20 02:45:50 +01:00
Nick Schonning 65ba0d92ef
Enable Rubocop RSpec/NotToNot () 2023-02-20 02:33:27 +01:00
Nick Schonning a2fdb388eb
Autofix Rubocop RSpec/ReturnFromStub () 2023-02-20 02:32:10 +01:00
Nick Schonning 21bf326356
Autofix Rubocop Rails/Pluck () 2023-02-20 02:28:40 +01:00
Nick Schonning 597767a9f7
Autofix Rubocop Rails/RedundantForeignKey () 2023-02-20 02:19:40 +01:00
Nick Schonning 8ef09813a2
Autofix Rubocop Style/EmptyMethod () 2023-02-20 02:18:54 +01:00
Nick Schonning e0e63b73ee
Autofix Rubocop RSpec/EmptyLineAfterHook () 2023-02-19 14:54:34 +09:00
Nick Schonning 81ad6c2e39
Autofix Rubocop Style/StringLiterals () 2023-02-19 07:38:14 +09:00
Nick Schonning ac3561098e
Autofix Rubocop RSpec/LetBeforeExamples () 2023-02-19 07:17:59 +09:00
Nick Schonning 1a02101100
Autofix Rubocop Style/EmptyLambdaParameter () 2023-02-19 07:12:06 +09:00
Nick Schonning 3680e032b4
Autofix Rubocop RSpec/EmptyLineAfterFinalLet () 2023-02-19 07:10:19 +09:00
Nick Schonning 2177daeae9
Autofix Rubocop Style/RedundantBegin () 2023-02-19 07:09:40 +09:00
Nick Schonning 167709f6b0
Autofix Rubocop Style/BlockDelimiters () 2023-02-19 07:00:17 +09:00
Nick Schonning c0d7c855b3
Autofix Rubocop RSpec/Capybara/FeatureMethods () 2023-02-19 06:59:00 +09:00
Nick Schonning 08289a38fa
Autofix Rubocop Style/TrailingCommaInArrayLiteral () 2023-02-19 06:54:30 +09:00
Nick Schonning 5069769cbe
Autofix Rubocop Style/TrailingCommaInHashLiteral () 2023-02-18 23:33:41 +09:00
Nick Schonning b4cbfff3eb
Autofix Rubocop RSpec/ExcessiveDocstringSpacing () 2023-02-18 12:47:37 +01:00
Nick Schonning c38bd17657
Autofix Rubocop Style/TrailingCommaInArguments () 2023-02-18 12:39:58 +01:00
Nick Schonning ab7816a414
Autofix Rubocop Style/Lambda () 2023-02-18 12:39:00 +01:00
Nick Schonning e2a3ebb271
Autofix Rubocop Style/IfUnlessModifier () 2023-02-18 12:37:47 +01:00
Nick Schonning 8aee4de034
Autofix Rubocop Style/PerlBackrefs () 2023-02-18 14:20:20 +09:00
Nick Schonning a6f77aa28a
Autofix Rubocop Lint/AmbiguousOperatorPrecedence () 2023-02-18 04:30:23 +01:00
Nick Schonning e2567df860
Enable Lint/RedundantCopDisableDirective () 2023-02-18 04:30:14 +01:00
Nick Schonning d65b2c1924
Apply Rubocop Style/RedundantConstantBase () 2023-02-18 04:30:03 +01:00
Nick Schonning a7db0b41cd
Autofix Rubocop Lint/ParenthesesAsGroupedExpression () 2023-02-18 04:00:05 +01:00
Nick Schonning e5cf23cf3a
Enable Rubocop RSpec/HooksBeforeExamples () 2023-02-18 03:59:57 +01:00
Nick Schonning efd424506a
Autofix Rubocop Style/RedundantPercentQ () 2023-02-18 03:32:57 +01:00
Nick Schonning c0a645f647
Autofix Rubocop RSpec/ExampleWording () 2023-02-18 03:26:20 +01:00
Nick Schonning 7a3d4c3d4b
Enable Rubocop RSpec/MultipleDescribes () 2023-02-18 03:25:47 +01:00
Nick Schonning 54318dcd6d
Autofix Rubocop RSpec/ClassCheck () 2023-02-18 03:24:16 +01:00
Nick Schonning 634368c491
Autofix Rubocop Lint/SymbolConversion () 2023-02-18 03:23:49 +01:00
Nick Schonning 6d42820e5d
Autofix Rubocop Lint/AmbiguousOperator () 2023-02-18 03:22:01 +01:00
Nick Schonning ac59d6f19f
Enable Rubocop Style/NumericLiterals () 2023-02-18 11:05:57 +09:00
Nick Schonning 669f6d2c0a
Run rubocop formatting except line length () 2023-02-18 06:56:20 +09:00
Nick Schonning 593bb8ce99
Autofix Rubocop Style/RaiseArgs () 2023-02-17 22:47:23 +09:00
Nick Schonning 6ed6c41724
Autofix Rubocop RSpec/EmptyLineAfterExample () 2023-02-17 21:46:00 +09:00
Nick Schonning 68b1071f86
Autofix Rubocop RSpec/BeNil () 2023-02-17 21:45:27 +09:00
Nick Schonning 936204b9ea
Autofix Rubocop Style/NestedParenthesizedCalls () 2023-02-17 21:43:10 +09:00
Nick Schonning 37914c8757
Autofix Rubocop Style/MethodCallWithoutArgsParentheses () 2023-02-17 21:36:14 +09:00
Nick Schonning 68a92c81bf
Generate minimimal Rubocop Todo file () 2023-02-16 15:33:50 +09:00