monorail
/
Scrython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bulk data was renamed

This commit is contained in:
Katelyn Gigante 2020-06-09 13:48:40 +10:00
parent 10ea4bfb61
commit b625f0a5fd
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
scrython/bulk_data/bulk_data.py
View File

@ -5,6 +5,7 @@ import asyncio
import aiohttp import aiohttp
import urllib.parse import urllib.parse
from threading import Thread from threading import Thread
import warnings
class BulkData(FoundationObject): class BulkData(FoundationObject):
""" """
@ -164,6 +165,10 @@ class BulkData(FoundationObject):
return self.scryfallJson['data'][num]['compressed_size'] return self.scryfallJson['data'][num]['compressed_size']
def bulk_permalink_uri(self, num): def bulk_permalink_uri(self, num):
warnings.warn("This method has been renamed to bulk_uri as per https://scryfall.com/blog/updates-to-bulk-data-and-cards-deprecation-notice-217", DeprecationWarning)
return self.bulk_uri(num)
def bulk_uri(self, num):
"""The URL that hosts the bulk file """The URL that hosts the bulk file
Args: Args:
@ -172,9 +177,9 @@ class BulkData(FoundationObject):
Returns: Returns:
string: A URI to download the compressed data string: A URI to download the compressed data
""" """
super(BulkData, self)._checkForTupleKey('data', num, 'permalink_uri') super(BulkData, self)._checkForTupleKey('data', num, 'uri')
return self.scryfallJson['data'][num]['permalink_uri'] return self.scryfallJson['data'][num]['uri']
def bulk_content_type(self, num): def bulk_content_type(self, num):
"""The MIME type of the file """The MIME type of the file

4
unittests/test_bulk.py
View File

@ -41,8 +41,8 @@ class TestBulk(unittest.TestCase):
self.assertIsInstance(bulk.bulk_compressed_size(0), int) self.assertIsInstance(bulk.bulk_compressed_size(0), int)
self.assertIsInstance(bulk.bulk_compressed_size(0, True), str) self.assertIsInstance(bulk.bulk_compressed_size(0, True), str)
def test_bulk_permalink_uri(self): def test_bulk_uri(self):
self.assertIsInstance(bulk.bulk_permalink_uri(0), str) self.assertIsInstance(bulk.bulk_uri(0), str)
def test_bulk_content_type(self): def test_bulk_content_type(self):
self.assertIsInstance(bulk.bulk_content_type(0), str) self.assertIsInstance(bulk.bulk_content_type(0), str)