The Wargroove mod didn't close the commander.json's file handle. The Wargroove mod will now close that file handle. The change for the mod can be viewed here: FlySniper/WargrooveArchipelagoMod@fc9aeb3
The change can be verified as present in this repository by viewing the binary data in the modAssets.dat file and searching for "commander.json"
This makes a few changes to logic to better match the 1.3 rando's logic. This fixes instances where the wrong items were expected, fixes a typo of "Lorqiana", moves the expert logic on "PotSS: Second area ledge" to only apply if on expert, and adds a new route to "DC: Mea Culpa altar" via Linen of Golden Thread + Three Gnarled Tongues
* CI: add a workflow to show flake8 violations in modified files of a PR
* modify a file to trigger the lint check
* CI: add a workflow to show mypy violations in modified files of a PR
* modify a file to trigger the type check
* Split flake8 and mypy into two parallel jobs; run a variant of the workflow on push event; modify a file to trigger the push workflow
* fail the task if there are syntax errors; remove old lint workflow
* Fix starting weapon locations usage
Makes a fresh copy of starting weapon locations when get_pool_core is ran
Should fix the issue of dangerous_weapon_locations getting appended to the list for other worlds past the first world that has dangerous StartingPosition, as well as running into the error if ExpandedPool was different between players
Credit for fix goes to @Silvris in the AP Discord
* Add new translation for Adventure and Archipidle in french
Add new translation for Adventure and Archipidle in french
* Add more store in setup page subnautica for more fairness
Add more store in setup page subnautica for more fairness
* tweak update merge #1685 for lua file
tweak update merge #1685 for lua file
* fix text
fix text
* fix wrong translation
fix wrong translation
* Yes it's better
Yes it's better
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
---------
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
* Fix documentation error
* init_creation
somehow this fix bug
* item_shuffle_fix
also a count as been corrected
* Fix_early_generation
* Update __init__.py
* Update __init__.py
fix version specific bug
* fix rule set for final boss
and did some reformation
(thanks kaito)
* Update Rules.py
the sword trio can now be in itself if before or actually themself
* Core: correct typing info for item_in_locations
Core: rename item_in_locations to item_name_in_location_names
Core: add actual item_name_in_locations
* item_shuffle_fix
also a count as been corrected
* Fix_early_generation
* fix rule set for final boss
and did some reformation
(thanks kaito)
* Update Rules.py
the sword trio can now be in itself if before or actually themself
* Fix the missing []
and switch to the good function
* - Cleanup and Black Sliver's suggestions
---------
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
Co-authored-by: Alex Gilbert <alexgilbert@yahoo.com>
* Adding SC2 macOS instructions
A few hours ago, I tested whether the client would run successfully on macOS (Send/Receive items, load maps, download maps, etc.). After the successful testing, I thought adding some documentation would be nice for those who want to play Archipelago on a macOS system.
* Don't need sudo
Turns out you don't need sudo to do the download_data, oops.
* Removed Extraneous Parantheses
__init__:
- Added exception for if the player has too many excluded abilities on keyblades.
- Fixed Action Abilities only on keyblades from breaking.
- Added proper support for ability quantity's instead of 1 of the ability
- Moved filling the localitems slot data to init instead of generate_output so I could easily unit test it
TestSlotData:
- Checks if the "localItems" part of slot data is filled. This is used for keeping track of local items and making sure nothing dupes
Corrects incorrect name listed for location in rules.py leading to logic rules failing to apply.
Swaps location names for incorrectly-named trainersanity checks in Viridian Gym
refactored and cleaned a bit SMWorld class for best practices:
- moved content of Regions.py and Rules.py in SMWorld
- moved appropiate code to their dedicated World core functions
- moved some Entrances being created in generate_basic to create_regions
more comeback check fixes:
- fixed setting progression door openers items local if doors_colors_rando is used
- enable comeback check only for filling stage as later stages (progression balancing, accessibility and spoiler playthrough) are prone to fail with it
Fixes some issues with typos and oversights logic generation in SC2
Rebalancing
Adds Vultures to Advanced tactics as train killers
Drops Firebats from basic unit pool and moves Goliaths from advanced tactics to standard
kindasneaki
Doug Hoskisson
lordlou
FlySniper
agilbert1412
Fabian Dill
ScootyPuffJr1
Exempt-Medic
axe-y
alwaysintreble
Fabian Dill
black-sliver
el-u
espeon65536
NewSoupVi
Scipio Wright
t3hf1gm3nt
TheLynk
zig-for
Abacys
Bicoloursnake
JaredWeakStrike
Alchav
Ziktofel
Adam Heinermann